Skip to content

chore: fix some minor issues in comments #19856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some minor issues in comments #19856

wants to merge 1 commit into from
+7 −7

Conversation

pingshuijie
Copy link

Purpose:

fix some minor issues in comments

Current Behavior:

New Behavior:

Testing Notes:

@pingshuijie pingshuijie requested a review from a team as a code owner July 22, 2025 10:27
@pingshuijie
Copy link
Author

Your commits are not signed and our branch protection rules require signed commits. For more information on how to create signed commits, please visit this page: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. Please use the button towards the bottom of the page to close this pull request and open a new one with signed commits.

Signed.

emlowe
emlowe requested changes Aug 26, 2025
View reviewed changes
chia/wallet/conditions.py
and self.mode_integer is None
):
raise ValueError("Must specify at least one committment. Anyone-can-send/recieve is not allowed.")
raise ValueError("Must specify at least one commitment. Anyone-can-send/recieve is not allowed.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, while correct, requires changing some test code, as the test code looks for this exact matching string while testing this exception flow

chia/wallet/conditions.py
def necessary_args(self) -> list[Program]:
if self._nothing_committed:
raise ValueError("Cannot generate necessary_args for a participant without committment information")
raise ValueError("Cannot generate necessary_args for a participant without commitment information")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, while correct, requires changing some test code, as the test code looks for this exact matching string while testing this exception flow

@emlowe emlowe added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emlowe emlowe emlowe requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog community-pr stale-pr Flagged as stale and in need of manual review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pingshuijie @emlowe @ChiaAutomation